#626 The diagram view includes 'Parallel' for parallel-aware nodes #638
Conversation
The reason why the
Thanks for the report. I'll fix that.
There's unfortunately no tests for the rendering. I really need to add some. |
{{ message }}
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #626, the Diagram doesn't include
Parallelfor parallel-aware nodes (Seq Scan, Append, Hash, etc). The 'Parallel' modifier is stripped during parsing and then added back in the graph view.This PR re-uses the
nodeNamefunction to make the two match.Render of
src/services/__tests__/12-line-wrapped-plans/05-planI considered removing the line that strips out 'Parallel'. But that would alter the
NODE_TYPEand it's not clear to me whether nodes of the same type are handled separately (i.e. do all 'Seq Scans' need to be treated alike, regardless of whether they're parallel?)Test Plan
Existing tests pass, and lints cleanly (except for one lint that is not modified by this PR.)
I'd love to write a test for this change, but I don't see existing examples that test the view, just the parser. Please point me in the right direction if there's a good way to test the view.